fix: add missing null-loader dependency #152

JamesMcMahon · 2020-01-18T03:01:04Z

Fix issue in #101

On the fresh project adding the vue add vuetify plugin results in a missing dependency:

WEBPACK  Failed to compile with 9 error(s)

Error in ./node_modules/vuetify/lib/components/VImg/VImg.js

  Module not found: 'null-loader' in '/Users/user/temp/vuetify-create-test'

KaelWD

Should be in dependencies of packages/vue-cli-plugin-vuetify

JamesMcMahon · 2020-01-18T04:33:54Z

@KaelWD I did a local build and didn't see it complain, so just to make sure I follow are you referring to the following block?

vue-cli-plugins/packages/vue-cli-plugin-vuetify/package.json

Lines 34 to 37 in addc5bc

    
           "devDependencies": { 
        
             "jest": "^24.9.0", 
        
             "vuetify-loader": "^1.2.2" 
        
           }

kierans · 2020-02-11T07:20:48Z

Great job @JamesMcMahon tracking this down and fixing it.

I'm not sure why @KaelWD wants null-loader in the dependencies given that this issue (which I've also just had) occurs when running test:unit.

It would be great to get this merged.

DRoet · 2020-02-11T08:46:06Z

This PR adds null-loader to the generated project, whilst the proper solution is to add it to packages/vue-cli-plugin-vuetify instead, since this is the package that uses it directly.

@KaelWD I did a local build and didn't see it complain, so just to make sure I follow are you referring to the following block?

vue-cli-plugins/packages/vue-cli-plugin-vuetify/package.json

Lines 34 to 37 in addc5bc

"devDependencies": {

"jest": "^24.9.0",

"vuetify-loader": "^1.2.2"

}

yes that is the correct location, but I think it should be under dependencies instead of devDependencies but I could be wrong

JamesMcMahon · 2020-02-11T13:49:16Z

Yeah I can make those changes.

The way you phrased it makes sense @DRoet. Thanks for clarifying.

Fix issue in vuetifyjs#101 On the fresh project adding the `vue add vuetify` plugin results in a missing dependency: ``` WEBPACK Failed to compile with 9 error(s) Error in ./node_modules/vuetify/lib/components/VImg/VImg.js Module not found: 'null-loader' in '/Users/jamie/temp/vuetify-create-test' ```

JamesMcMahon · 2020-02-12T01:29:43Z

PR has been updated. I removed the dependency from ad-hoc and added to the package.json.

JamesMcMahon · 2020-02-12T01:53:39Z

Confirmed and tested locally that this works.

Note for myself in case I need to make further changes, https://cli.vuejs.org/dev-guide/plugin-dev.html#installing-plugin-locally.

JamesMcMahon · 2020-02-16T00:42:34Z

I am just checking in on this. I see two approvals, is there anything I need to do before this is merged?

DRoet · 2020-02-17T07:56:26Z

nope, it just needs to get merged/released by someone who has the time to do it

DRoet · 2020-03-14T11:11:06Z

@johnleider Do you have some time to merge this in and do a release?

merceyz · 2020-04-26T10:48:31Z

Need to change the loader to use require.resolve('null-loader') otherwise we're depending on hoisting which is a terrible idea

vue-cli-plugins/packages/vue-cli-plugin-vuetify/index.js

Line 48 in 908f65d

sassRule.use('null-loader').loader('null-loader')

Should be sassRule.use('null-loader').loader(require.resolve('null-loader'))

vue-cli-plugins/packages/vue-cli-plugin-vuetify/index.js

Line 52 in 908f65d

scssRule.use('null-loader').loader('null-loader')

Should be scssRule.use('null-loader').loader(require.resolve('null-loader'))

JamesMcMahon · 2020-04-26T16:43:49Z

Want to create a separate PR for that? I want to scope this PR down to just installing the dependency. This has been broken for 6 or so months now and this PR has been sitting approved for two months so I would like to see it merged so we can build additional needed changes on top of it.

…

On Sun, Apr 26, 2020, 05:48 Kristoffer K. ***@***.***> wrote: Need to change the loader to use require.resolve('null-loader') otherwise we're depending on hoisting which is a terrible idea https://github.com/vuetifyjs/vue-cli-plugins/blob/908f65d35478da2cd9df3569c2ce4c5ca1910468/packages/vue-cli-plugin-vuetify/index.js#L48 Should be sassRule.use('null-loader').loader(require.resolve('null-loader')) https://github.com/vuetifyjs/vue-cli-plugins/blob/908f65d35478da2cd9df3569c2ce4c5ca1910468/packages/vue-cli-plugin-vuetify/index.js#L52 Should be scssRule.use('null-loader').loader(require.resolve('null-loader')) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#152 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG7ZRCHEM7YKSC2W4LV2CDROQGQXANCNFSM4KIQUB4A> .

dwalters18 · 2020-05-07T17:36:44Z

@KaelWD can we get this merged? :)

DRoet · 2020-05-08T08:32:15Z

@johnleider friendly ping

KaelWD requested changes Jan 18, 2020

View reviewed changes

JamesMcMahon force-pushed the dependency-fix branch from 7c4aff2 to 31d3724 Compare February 12, 2020 01:21

JamesMcMahon force-pushed the dependency-fix branch from 31d3724 to 41ea4de Compare February 12, 2020 01:27

JamesMcMahon requested a review from KaelWD February 12, 2020 01:54

KaelWD approved these changes Feb 13, 2020

View reviewed changes

DRoet approved these changes Feb 13, 2020

View reviewed changes

KaelWD changed the title ~~Add missing null-loader dependency~~ fix: add missing null-loader dependency Jul 20, 2020

KaelWD merged commit 983a796 into vuetifyjs:master Jul 20, 2020

lgarczyn mentioned this pull request May 5, 2021

Removed deprecated null-loader dependency #266

Merged

merceyz mentioned this pull request Jul 3, 2021

chore(compat): update extensions list yarnpkg/berry#3082

Merged

3 tasks

JamesMcMahon deleted the dependency-fix branch October 22, 2022 19:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add missing null-loader dependency #152

fix: add missing null-loader dependency #152

JamesMcMahon commented Jan 18, 2020 •

edited

Loading

KaelWD left a comment

JamesMcMahon commented Jan 18, 2020 •

edited

Loading

kierans commented Feb 11, 2020

DRoet commented Feb 11, 2020

JamesMcMahon commented Feb 11, 2020

JamesMcMahon commented Feb 12, 2020

JamesMcMahon commented Feb 12, 2020

JamesMcMahon commented Feb 16, 2020

DRoet commented Feb 17, 2020

DRoet commented Mar 14, 2020

merceyz commented Apr 26, 2020

JamesMcMahon commented Apr 26, 2020 via email •

edited

Loading

dwalters18 commented May 7, 2020

DRoet commented May 8, 2020

fix: add missing null-loader dependency #152

fix: add missing null-loader dependency #152

Conversation

JamesMcMahon commented Jan 18, 2020 • edited Loading

KaelWD left a comment

Choose a reason for hiding this comment

JamesMcMahon commented Jan 18, 2020 • edited Loading

kierans commented Feb 11, 2020

DRoet commented Feb 11, 2020

JamesMcMahon commented Feb 11, 2020

JamesMcMahon commented Feb 12, 2020

JamesMcMahon commented Feb 12, 2020

JamesMcMahon commented Feb 16, 2020

DRoet commented Feb 17, 2020

DRoet commented Mar 14, 2020

merceyz commented Apr 26, 2020

JamesMcMahon commented Apr 26, 2020 via email • edited Loading

dwalters18 commented May 7, 2020

DRoet commented May 8, 2020

JamesMcMahon commented Jan 18, 2020 •

edited

Loading

JamesMcMahon commented Jan 18, 2020 •

edited

Loading

JamesMcMahon commented Apr 26, 2020 via email •

edited

Loading